Skip to content

/ elixirscript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually, "yes, console" #493

Merged
merged 2 commits into from Aug 20, 2019
Merged

Actually, "yes, console" #493

merged 2 commits into from Aug 20, 2019

Conversation

@workingjubilee
Copy link
Contributor

workingjubilee commented Aug 20, 2019 •
edited

As discussed in #230!

This includes a change to .eslintrc.js and also some individual file changes to selectively disable ESLint's behavior in files where logically a console method does belong, or where the grounding logic of the rule ("avoid cluttering the browser") does not apply.
@workingjubilee
Disables "no-console" linting in extant test files
44cb70c
@sourcelevel-bot
sourcelevel-bot bot reviewed Aug 20, 2019
View changes
src/javascript/lib/core/erlang_compat/elixir_errors.js Outdated Show resolved Hide resolved
@workingjubilee workingjubilee force-pushed the workingjubilee:jubilee-yes-console branch 2 times, most recently from a6014d3 to 33f99b6 Aug 20, 2019
@sourcelevel-bot
sourcelevel-bot bot reviewed Aug 20, 2019
View changes
src/javascript/lib/core/special_forms.js Outdated Show resolved Hide resolved
@workingjubilee
Disable "no-console" linting for specific console.warns
Loading status checks…
fab74b8 
These all are exceptional cases of warnings where the warning is
far more important than adhering to a style guide on lints, even if
some of them might potentially show up in the browser. Each is a
hand-picked exception, so these use in-file comment overrides.

Rationales are included in preceding comments.
@workingjubilee workingjubilee force-pushed the workingjubilee:jubilee-yes-console branch from 33f99b6 to fab74b8 Aug 20, 2019
@sourcelevel-bot
Copy link

sourcelevel-bot bot commented Aug 20, 2019

SourceLevel has finished reviewing this Pull Request and has found:

  • 4 fixed issues! 🎉

You can see more details about this review at https://app.sourcelevel.io/github/elixirscript/elixirscript/pulls/493.
@workingjubilee
Copy link
Contributor Author

workingjubilee commented Aug 20, 2019 •
edited

After reviewing SourceLevel's output, I believe the dark magic that powers it follows master's .eslintrc.js even when reviewing a PR which itself changes those rules, and so there is not going to be an obvious change that SourceLevel can detect for any of these items. I'm hoping the .eslintrc.js change "takes" after merge, but I am honestly puzzled that it doesn't respect /* eslint-disable-next-line */ or /* eslint-disable-line */ and am not sure what to make of that. /* eslint-disable no-console */ seems to work, though.

Anyways, hope I didn't cause a nuisance by playing with the CI bots, I'm done with that now! It just seemed like the most expedient way to tease out how the analyzer worked. And now hopefully there will be less noise in the linter.
@bryanjos bryanjos merged commit cc8a08a into elixirscript:master Aug 20, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
sourcelevel SourceLevel has found 4 fixed issues.
Details
@bryanjos
Copy link
Collaborator

bryanjos commented Aug 20, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcelevel-bot sourcelevel-bot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@workingjubilee @bryanjos
You can’t perform that action at this time.