JS: add req.files as a RequestInputAccess in the Express model#4331
Merged
codeql-ci merged 2 commits intogithub:mainfrom Sep 25, 2020
Merged
JS: add req.files as a RequestInputAccess in the Express model#4331codeql-ci merged 2 commits intogithub:mainfrom
codeql-ci merged 2 commits intogithub:mainfrom
Conversation
esbena
requested changes
Sep 24, 2020
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
LGTM, some minor comment on the test case.
Is .files really only relevant for express?
javascript/ql/test/query-tests/Security/CWE-611/libxml.noent.js
Outdated
Show resolved
Hide resolved
esbena
approved these changes
Sep 24, 2020
Contributor
Author
I think so. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets a TP/TN for this example vulnerability from Damn Vulnerable NodeJS Application.
For most intents and purposes
req.filesbehaves the same asreg.body(it is completely user controllable).So I just reused the
kind = "body".