Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35018: Sax parser provides no user access to lexical handlers #20958

Merged
merged 6 commits into from Aug 9, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jun 18, 2020

Co-Authored-By: Jonathan Gossage jgossage@gmail.com

https://bugs.python.org/issue35018

Co-Authored-By: Jonathan Gossage <jgossage@gmail.com>
Copy link
Contributor

@scoder scoder left a comment

Looks good to me, just one issue regarding the usage documentation.

Lib/xml/sax/handler.py Outdated Show resolved Hide resolved
Lib/xml/sax/handler.py Outdated Show resolved Hide resolved
Doc/library/xml.sax.handler.rst Outdated Show resolved Hide resolved
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Jun 24, 2020

Hi, @scoder. Can this PR be merged?

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Aug 8, 2020

@scoder Ping?

@scoder scoder merged commit e28b8c9 into python:master Aug 9, 2020
4 checks passed
@scoder
Copy link
Contributor

scoder commented Aug 9, 2020

Let's get this in. Thanks @jgossage and @ZackerySpytz for you contribution.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants