fix(tabs): fix typing of IonTabs refs#21376
Closed
aivinog1 wants to merge 1 commit into
Closed
Conversation
add IonTabs to proxies.ts to make it works with refs of type HTMLIonTabsElement. Refs ionic-team#20669.
Contributor
Author
|
@elylucas Hello! Would you like to review this PR, please? This is about 2 months passed since I created this :) |
Contributor
Author
|
@elylucas @brandyscarney @liamdebeasi Hello! May I ask when this will be reviewed? :) There is already some time passed and still no review. |
Contributor
|
Hey there, I followed up on this issue in #20669 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Current behavior: IonTabs in the React package doesn't accept HTMLIonTabsElement in refs.
Issue Number: #20669
What is the new behavior?
Does this introduce a breaking change?
Other information