JS: Add missing ES2021 features#4282
Merged
codeql-ci merged 6 commits intogithub:mainfrom Sep 22, 2020
Merged
Conversation
erik-krogh
force-pushed
the
es2021
branch
2 times, most recently
from
c01c008 to
db33803
Compare
Contributor
|
LGTM.
I would like to see an evaluation of |
erik-krogh
added
the
Awaiting evaluation
Contributor
Author
Here is an evaluation of that specific commit: https://git.semmle.com/erik/dist-compare-reports/tree/profiling-erik-krogh.northeurope.cloudapp.azure.com_1600769777900 |
erik-krogh
removed
the
Awaiting evaluation
esbena
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the obvious features we were missing from ES2021: https://github.com/tc39/proposals/blob/master/finished-proposals.md
The
&&=/||=/??=operators were somewhat straightforward, as we already had support for these operators in TypeScript.I have not added anything for
WeakRefs.I don't have plans of running any evaluation.