Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on issues and pull requests from gh #517

Open
arohner opened this issue Feb 20, 2020 · 7 comments
Open

Comment on issues and pull requests from gh #517

arohner opened this issue Feb 20, 2020 · 7 comments

Comments

@arohner
Copy link

@arohner arohner commented Feb 20, 2020

Describe the feature or problem you’d like to solve

gh issue create is excellent, and I love being able to write issues using $EDITOR. I would also like to comment on issues using the same workflow.

Proposed solution

gh issue comment #123 would behave similarly to gh issue create. The CLI would open $EDITOR, and submit the comment after $EDITOR closes.

Using $EDITOR to type longer comments is awesome!

Additional context

When we do this we should make it available for both issues and pull requests.

@arohner arohner added the enhancement label Feb 20, 2020
@tierninho tierninho added the issue label Feb 20, 2020
@tierninho tierninho changed the title [enhancement] comment and edit issues add ability to comment on and edit issues Feb 20, 2020
@billygriffin
Copy link
Member

@billygriffin billygriffin commented Mar 10, 2020

Thanks @arohner! We try to keep our issues (as best as possible) organized by units of work that we or someone from the community could pick up, so I'd like to split these two things out as they're a bit different, and also expand the scope of each to issues and pull requests as opposed to just issues. I'm going to edit this one to be scoped to commenting, and if you'd like to make a new issue for editing an existing issue or pull request, you're welcome to do so. Thanks!

@billygriffin billygriffin changed the title add ability to comment on and edit issues Comment on issues and pull requests from gh Mar 10, 2020
@vkuznet
Copy link

@vkuznet vkuznet commented Apr 24, 2020

+1

@dmngdsm
Copy link

@dmngdsm dmngdsm commented May 28, 2020

+1 for gh issue comment #123

@shindere
Copy link

@shindere shindere commented Jun 3, 2020

+1 for gh issue comment #123

Nitpick: it would be even better without the # which would introduce plenty of confusions in shell commands.

As a sidenote, the git-hub program already supports this feature so if ghaims at replacing it, it would really be nice and convenient to have this.

(This comment has actually been written with git hub issue comment)

@Pablo-No
Copy link

@Pablo-No Pablo-No commented Jun 13, 2020

I would ❤️ to have this feature. But I agree with @shindere , it would be better without the #.

@danieldjewell
Copy link

@danieldjewell danieldjewell commented Jun 14, 2020

without the #

100% agree - the standard convention of gh (and also, hub) is to leave out the # ... Also, since # is the typical shell comment, if used, I'm 99% sure you'd have to escape it. See below.

Relatedly, consider #528 in conjunction with editing - they are two distinct features, but they are related 😁

Compare:

$ echo hello #hello 
hello
$ echo hello \#hello
hello #hello

Also, I might need more coffee ... but I can't find a way to view all of the comments in an issue/PR? It seems to just show the top? (On an interesting side note, hub issue show will happily display both issues/PRs whereas gh issue view will only view issues and not PRs. As I recall, the ID# between the two is unique - i.e. there will never be an issue number 1 and PR number 1 -- If that's the case, I'm not 100% sure what's better, I suppose displaying an error if you run gh issue view <PR#> but you're specifically looking for an issue does serve as validation of which one you're querying... )

@AliabbasMerchant
Copy link
Contributor

@AliabbasMerchant AliabbasMerchant commented Jun 16, 2020

On an interesting side note, hub issue show will happily display both issues/PRs whereas gh issue view will only view issues and not PRs. As I recall, the ID# between the two is unique - i.e. there will never be an issue number 1 and PR number 1 -- If that's the case, I'm not 100% sure what's better, I suppose displaying an error if you run gh issue view <PR#> but you're specifically looking for an issue does serve as validation of which one you're querying...

@danieldjewell This is being addressed in #1153 and #1131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.