Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 1-4 #94

Open
wants to merge 1 commit into
base: master
from
Open

Labs 1-4 #94

wants to merge 1 commit into from

Conversation

@maxdubinin
Copy link

maxdubinin commented Oct 1, 2019

No description provided.

Copy link
Member

tshemsedinov left a comment

Use \n line breaks, all modern editors support this.

const obj = {};
for (const a of arr) {
const type = typeof a;
obj[type] = obj[type] ? ++obj[type] : 1;

This comment has been minimized.

@tshemsedinov

tshemsedinov Oct 2, 2019 Member

Use additional identifiers (variables) and try to rewrite this with if-statement to improve readability.

@@ -15,7 +15,7 @@
],
"linebreak-style": [
"error",
"unix"
"windows"

This comment has been minimized.

@tshemsedinov

tshemsedinov Oct 2, 2019 Member

Don't change configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.