Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Add models for the Chi web framework#343

Merged
smowton merged 1 commit intogithub:mainfrom
smowton:smowton/feature/chi-models
Sep 16, 2020
Merged

Add models for the Chi web framework#343
smowton merged 1 commit intogithub:mainfrom
smowton:smowton/feature/chi-models

Conversation

@smowton
Copy link
Contributor

@smowton smowton commented Sep 15, 2020

This is mostly simple as the framework uses ordinary net/http methods and ordinary Go contexts for most purposes.

@smowton smowton requested a review from a team September 15, 2020 16:08
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged we should add Chi to the list of frameworks we support

}

/**
* Functions that extract URL parameters, considered as a source of untrusted flow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Functions that extract URL parameters, considered as a source of untrusted flow.
* Methods that extract URL parameters, considered as a source of untrusted flow.

// Code generated by depstubber. DO NOT EDIT.
// This is a simple stub for github.com/go-chi/chi, strictly for use in testing.

// See the LICENSE file for information about the licensing of the original library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the LICENSE file part of this PR?

This is mostly simple as the framework uses ordinary net/http methods and ordinary Go contexts for most purposes.
@smowton smowton force-pushed the smowton/feature/chi-models branch from d89b48d to 1bf366c Compare September 16, 2020 08:14
@smowton
Copy link
Contributor Author

smowton commented Sep 16, 2020

@max-schaefer done

@smowton smowton merged commit fee596a into github:main Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments