robert / bashplotlib

forked from glamp/bashplotlib

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSAB] Task 2: Allow users to pass titles for the x- and y-axes #2

Open

robert wants to merge 1 commit into master from rob-axis-labels

Owner

robert commented Mar 31, 2019 •

edited

This is one way to solve Task 2 in https://robertheaton.com/2019/04/14/open-source-for-advanced-beginners-1-bashplotlib/ .

Test:

I ran:

from bashplotlib.scatterplot import plot_scatter

x_coords = [-10,20,30]
y_coords = [-10,20,30]
width = 10
char = 'x'
color = 'default'
title = 'Test Title'

plot_scatter(
    None,
    x_coords,
    y_coords,
    width,
    char,
    color,
    title,
    xtitle="My X Axis",
    ytitle="My Y Axis")

and got:


        [OSAB] Allow users to pass titles for the x- and y-axes

7aee70e

robert reviewed

bashplotlib/scatterplot.py

  
            plotted = set()

            x_scale = get_scale(xs, False, size)

robert Mar 31, 2019 Author Owner

I assigned these scales to variables because we were calling the get_scale function a lot and it was getting a bit messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.