Skip to content

/ go-github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove graduated GitHub v3 API preview headers #1616

Closed
gmlewis opened this issue Aug 22, 2020 · 3 comments
Closed

Remove graduated GitHub v3 API preview headers #1616

gmlewis opened this issue Aug 22, 2020 · 3 comments
Assignees
@vikkyomkar
Labels
enhancement good first issue

Comments

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 22, 2020

GitHub Developer v3 API announcement:
https://developer.github.com/changes/2020-08-20-graduate-machine-man-and-sailor-v-previews/

These custom preview headers have now graduated and need to be remove from this repo:

  • application/vnd.github.machine-man-preview+json
  • application/vnd.github.sailor-v-preview+json

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!
@vikkyomkar
Copy link
Contributor

@vikkyomkar vikkyomkar commented Aug 22, 2020

I would like to contribute to this
@guacamole
Copy link

@guacamole guacamole commented Aug 22, 2020

hey @gmlewis, can i start working on this one?
@gmlewis
Copy link
Collaborator Author

@gmlewis gmlewis commented Aug 22, 2020

Thanks, you two. It looks like @vikkyomkar was first, so it is yours.
@vikkyomkar vikkyomkar mentioned this issue Aug 24, 2020
Merged
@gmlewis gmlewis closed this in 8e1859f Sep 17, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
@vikkyomkar
Remove graduated GitHub v3 API preview headers (google#1618)
ae39d1c 
Fixes: google#1616.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikkyomkar vikkyomkar

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@gmlewis @vikkyomkar @guacamole