Make rules_python_external functional #354
Merged
Conversation
alexeagle
force-pushed the
alexeagle:external2
branch
5 times, most recently
from
4c0f660
to
d0c84b4
| ) | ||
|
|
||
| load("@rules_python_external//:repositories.bzl", "rules_python_external_dependencies") | ||
| load("@rules_python//experimental/rules_python_external:repositories.bzl", "rules_python_external_dependencies") |
thundergolfer
Aug 30, 2020
Collaborator
I don't think this works while @rules_python points at the 0.0.2 release, because the starlark file doesn't exist in that version. But it'll work in integration test because the http_archive.url is subbed out.
Probably worth a TODO to update the above http_archive.url when possible.
I don't think this works while @rules_python points at the 0.0.2 release, because the starlark file doesn't exist in that version. But it'll work in integration test because the http_archive.url is subbed out.
Probably worth a TODO to update the above http_archive.url when possible.
alexeagle
Aug 30, 2020
Author
Collaborator
ah, we need a step during releases that bumps the version everywhere, including the readme and all the examples. In rules_nodejs we have that automated as part of the release. Happy to do that as a followup, are the release steps documented though?
ah, we need a step during releases that bumps the version everywhere, including the readme and all the examples. In rules_nodejs we have that automated as part of the release. Happy to do that as a followup, are the release steps documented though?
- Clean up files that aren't needed now that it's a subdirectory of rules_python - Move the example into the top-level examples From the checklist in #352 this is the third item.
alexeagle
merged commit 6ed1fe5
into
bazelbuild:master
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reminder of the plan:
bring in the repo to a subdirectory, preserving git history and contributorsclean up the code, remove mypy, get it functional in that subdirectory