Skip to content

/ spotless

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guaranteed binary and source compatibility between releases of Scalafmt #260

Merged
merged 2 commits into from Jul 24, 2018
Merged

Use guaranteed binary and source compatibility between releases of Scalafmt #260

merged 2 commits into from Jul 24, 2018

Conversation

@joan38
Copy link
Contributor

joan38 commented Jul 7, 2018

Fix for #252
@joan38 joan38 mentioned this pull request Jul 7, 2018
Merged
0 of 3 tasks complete
@joan38 joan38 force-pushed the joan38:scalafmt-fix branch 2 times, most recently from 1704067 to 9da5575 Jul 7, 2018
@nedtwigg
Copy link
Member

nedtwigg commented Jul 8, 2018

Looks like the change breaks older versions of scalafmt?
Joan Goyeau
Use guaranteed binary and source compatibility between releases of Sc…
Loading status checks…
3ae984a 
…alafmt
@joan38 joan38 force-pushed the joan38:scalafmt-fix branch from 9da5575 to 3ae984a Jul 9, 2018
@joan38
Copy link
Contributor Author

joan38 commented Jul 9, 2018 •
edited

This drops the support for scalafmt < v0.7.0-RC1. Is it good enough? It's a pretty old version...
@joan38
Copy link
Contributor Author

joan38 commented Jul 9, 2018 •
edited

I tried to run the tests with gradle test but it doesn't seem to be the way to do and the CONTRIBUTING.md doesn't specify how to run the tests...
@joan38 joan38 mentioned this pull request Jul 9, 2018
Closed
@nedtwigg
Copy link
Member

nedtwigg commented Jul 9, 2018

Great! All it needs now is updated CHANGES.md:

  • a summary of the change
  • a link to the newly created PR

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.
@nedtwigg
Copy link
Member

nedtwigg commented Jul 17, 2018

bump
@joan38 joan38 mentioned this pull request Jul 24, 2018
Closed
@joan38 @nedtwigg
Update CHANGE.md
Loading status checks…
a323bc6
@nedtwigg nedtwigg merged commit 4cbb787 into diffplug:master Jul 24, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@joan38 @nedtwigg
You can’t perform that action at this time.