Skip to content

/ string_decoder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 8.9.4. #6

Merged
merged 4 commits into from Mar 6, 2018
Merged

Update to node 8.9.4. #6

merged 4 commits into from Mar 6, 2018

Conversation

@mcollina
Copy link
Member

mcollina commented Feb 28, 2018

As titled.
@mcollina mcollina requested review from mafintosh and calvinmetcalf Feb 28, 2018
@mcollina mcollina mentioned this pull request Feb 28, 2018
Closed
@mafintosh
Copy link
Member

mafintosh commented Feb 28, 2018

LGTM
@mafintosh
mafintosh approved these changes Feb 28, 2018
View changes
@mcollina mcollina force-pushed the update-8-9-4 branch 4 times, most recently from e0d4e29 to d8f627a Mar 1, 2018
mcollina added 3 commits Feb 28, 2018
@mcollina
Update to node 8.9.4.
aa3a6d2
@mcollina
fixed tests in old nodes.
91f5a76
@mcollina
Added npm run ci.
8db89fd
@mcollina mcollina force-pushed the update-8-9-4 branch from d8f627a to 8db89fd Mar 5, 2018
@mcollina
Back support for Node < 8.
3dbdece
@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

CI: https://ci.nodejs.org/view/MyJobs/job/string_decoder-pipeline/2/
@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

CI: https://ci.nodejs.org/view/MyJobs/job/string_decoder-pipeline/5/console
(this should be green)
@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

CI passed.
@mcollina mcollina merged commit f12f26e into master Mar 6, 2018
@mcollina mcollina deleted the update-8-9-4 branch Mar 6, 2018
@mcollina mcollina mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh

@calvinmetcalf calvinmetcalf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mcollina @mafintosh
You can’t perform that action at this time.