Skip to content

/ deploy-nodejs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized Dockerfile #3

Merged
merged 2 commits into from Oct 17, 2019
Merged

optimized Dockerfile #3

merged 2 commits into from Oct 17, 2019

Conversation

@primetheus
Copy link
Contributor

primetheus commented Oct 17, 2019

Major changes (TL;DR) include:

  • Switched to python:alpine for the size
  • Installing nodejs and npm via apk instead of source
  • Installing yq and aws-sam-cli via pip

The build time is under a minute and Docker image size is 355MB
@primetheus
optimized Dockerfile
Loading status checks…
8939eef
@primetheus primetheus requested a review from admiralAwkbar Oct 17, 2019
@admiralAwkbar
admiralAwkbar approved these changes Oct 17, 2019
View changes
@admiralAwkbar
Merge branch 'master' into primetheus/dockerfile
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec94edf
@admiralAwkbar admiralAwkbar merged commit 41e9283 into master Oct 17, 2019
1 check failed
1 check failed
Source linter Source linter
Details
@admiralAwkbar admiralAwkbar deleted the primetheus/dockerfile branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admiralAwkbar admiralAwkbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@primetheus @admiralAwkbar
You can’t perform that action at this time.