Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README improvements #8

Merged
merged 5 commits into from Jul 9, 2018
Merged

README improvements #8

merged 5 commits into from Jul 9, 2018

Conversation

@mscheel
Copy link
Contributor

mscheel commented May 15, 2018

  1. Fix casing of HAT (not hat) in three README files
mscheel added 2 commits May 15, 2018
Fix casing for HAT
Clarify where the button and light can be found when not using a breadboard and instead using the Rainbow HAT (Hardware Attached on Top).
@googlebot
Copy link

googlebot commented May 15, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@mscheel
Copy link
Contributor Author

mscheel commented May 15, 2018

I signed it!

@googlebot
Copy link

googlebot commented May 15, 2018

CLAs look good, thanks!

@devunwired devunwired self-requested a review Jul 3, 2018
Copy link
Member

devunwired left a comment

This repository has three README files, which all contain this text. The update should include all of them.

Also, calling out the I/O on the Rainbow HAT is a good idea but we should do so visually with an image of the HAT (the same way we call out the other schematic). We can add this separately, so I'd remove that line from this PR.

mscheel added 3 commits Jul 4, 2018
Fix casing for HAT
Fix casing for HAT
This reverts commit 1980494.
@mscheel
Copy link
Contributor Author

mscheel commented Jul 4, 2018

Requested changes have been addressed, thanks Dave for the thoughtful review

@devunwired devunwired merged commit 862b2cf into androidthings:master Jul 9, 2018
1 check passed
1 check passed
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.