Write the InstallLocation to fixed registry key#13576
Merged
anmenaga merged 1 commit intoPowerShell:masterfrom Sep 10, 2020
Merged
Write the InstallLocation to fixed registry key#13576anmenaga merged 1 commit intoPowerShell:masterfrom
anmenaga merged 1 commit intoPowerShell:masterfrom
Conversation
Collaborator
@heaths You can open new issue in https://github.com/MicrosoftDocs/PowerShell-Docs and add reference in the PR description.
|
Contributor
Author
|
Thanks, @iSazonov. I opened MicrosoftDocs/PowerShell-Docs#6589 and updated the PR description. |
iSazonov
approved these changes
Sep 5, 2020
TravisEz13
approved these changes
Sep 10, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Write an InstallLocation registry value to a location specific to the bitness and release tag so that it doesn't change from release to release. Fixes #13573
Build the win7-x64 package and installed to make sure it works correctly. The key should also be documented, but I'm not sure where in this repo that would be - perhaps something separate in your docs repo for docs.microsoft.com, if you have one.
PR Context
Quick fix for a customer issue in which I was mentioned. The customer was using a location that not only changes from version to version, but should not be used because that registry isn't meant for direct consumption. Windows Installer has always taken a very firm stance on, "if it's not documented, it's not supported".
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.Experimental feature(s) neededExperimental feature name(s):Not ApplicableMake sure you've added a new test if existing tests do not effectively test the code changedI have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: