Skip to content

Write the InstallLocation to fixed registry key#13576

Merged
anmenaga merged 1 commit intoPowerShell:masterfrom
heaths:issue13573
Sep 10, 2020
Merged

Write the InstallLocation to fixed registry key#13576
anmenaga merged 1 commit intoPowerShell:masterfrom
heaths:issue13573

Conversation

@heaths
Copy link
Contributor

@heaths heaths commented Sep 4, 2020

PR Summary

Write an InstallLocation registry value to a location specific to the bitness and release tag so that it doesn't change from release to release. Fixes #13573

Build the win7-x64 package and installed to make sure it works correctly. The key should also be documented, but I'm not sure where in this repo that would be - perhaps something separate in your docs repo for docs.microsoft.com, if you have one.

PR Context

Quick fix for a customer issue in which I was mentioned. The customer was using a location that not only changes from version to version, but should not be used because that registry isn't meant for direct consumption. Windows Installer has always taken a very firm stance on, "if it's not documented, it's not supported".

PR Checklist

@ghost ghost assigned anmenaga Sep 4, 2020
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 4, 2020

The key should also be documented

@heaths You can open new issue in https://github.com/MicrosoftDocs/PowerShell-Docs and add reference in the PR description.

GitHub
The official PowerShell documentation sources. Contribute to MicrosoftDocs/PowerShell-Docs development by creating an account on GitHub.

@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 4, 2020
@heaths
Copy link
Contributor Author

heaths commented Sep 4, 2020

Thanks, @iSazonov. I opened MicrosoftDocs/PowerShell-Docs#6589 and updated the PR description.

@anmenaga anmenaga merged commit af6d9fb into PowerShell:master Sep 10, 2020
@heaths heaths deleted the issue13573 branch September 10, 2020 18:37
@iSazonov iSazonov added this to the 7.1.0-RC.1 milestone Sep 11, 2020
@ghost
Copy link

ghost commented Sep 29, 2020

🎉v7.1.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Setup: Setup 7 (x86, x64) does not write InstallLocation

4 participants