Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
test: fix flaky sample tests #882
Conversation
laljikanjareeya
force-pushed the
laljikanjareeya:flaky-sample-test
branch
from
37c6c6d
to
1a66183
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 18 18
Lines 10842 10842
Branches 378 393 +15
=======================================
Hits 10580 10580
Misses 259 259
Partials 3 3 Continue to review full report at Codecov.
|
laljikanjareeya
changed the title
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
bcoe
merged commit 34a71aa
into
googleapis:master
In the recent PR all the tests was passing successfully but,
afterhook was failing.In Document mention that Log entries written shortly before the delete operation might not be deleted..
Modify delete logs logic in
afternow it will delete logs that has been created before 1 hr.Fixes #761