Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help devs with abi checks #11047

Open
rwalker-com opened this issue Jul 14, 2020 · 1 comment
Open

help devs with abi checks #11047

rwalker-com opened this issue Jul 14, 2020 · 1 comment

Comments

@rwalker-com
Copy link
Contributor

@rwalker-com rwalker-com commented Jul 14, 2020

Problem

Once one has reproduced an abi test failure, there's this suggestion in the log output (just an example):
Confirm the diff by rerunning before and after this test failed with SOLANA_ABI_DUMP_DIR!', runtime/src/serde_snapshot/tests.rs:285:5

Proposed Solution

Three suggestions:

  1. have the tests make the DUMP_DIR directory if the env var is set. When the variable is set and the directory doesn't exist, nothing happens. Maybe even always dump for ABI (there's always farf)
  2. remove the exclamation point from the log message
  3. clarify the steps necessary to compare ABIs (with examples)
@ryoqun
Copy link
Member

@ryoqun ryoqun commented Jul 14, 2020

Thanks for suggestions! I'll address these once we land #10914. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants