Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate kick and kickban packets into one (more versatile) handler #152

Closed
wants to merge 34 commits into from

Conversation

@in1tiate
Copy link
Contributor

in1tiate commented Apr 29, 2020

oldmud0 and others added 30 commits Apr 18, 2020
CR likely stands for "CentsRaidensnake." Like the Case Cafe mega-merge
before it, this was not a clean merge, and it had to be split up into
two parts: the actual changes, and the attempt it made to reformat the
entire code via clang-format.

This branch had a complicated set of changes that would be difficult to
describe in this commit message. It would be better described in a
proper changelog.
Indentation fixed to 2 spaces per tab. Braces set to Stroustrup style.
Lines reflow at 80 characters. One-line method bodies are on the same
line as the signature. Space always after `//`. No indentation
on preprocessor macros. Includes are sorted lexicographically.

If you don't want to see this commit on blames, use the hidden
whitespace option on GitHub, or use `-w` in git-blame.
"shownames" isn't a word, and what does "Custom shownames" even mean anyway?
"Show custom IC names" should do a better job at explaining what this option does.
As far as I know checkbox is more common
This reverts commit cd034b9.
As far as I know checkbox is more popular than tickbox, on Wikipedia for example it's called checkbox.
And some spell checkers will highlight tickbox as a typo, but not checkbox.
No need for two exclamations
Thanks Initiate for actually fixing this
Without an option to change it users will complain
Thanks Initiate for telling me how to change this
I didn't format anything tho that is at the end
Did you know you could scale the iclog with ctrl + mouse wheel?
stonedDiscord and others added 3 commits Apr 24, 2020
this kept it from buildinf with MSVC
@oldmud0
Copy link
Member

oldmud0 commented Apr 29, 2020

No more features allowed in 2.7-rc. Moved base to master. Wait for merge.

Also, the KK (kick) message can already contain a reason, so I do not really understand the point of this new packet.

@in1tiate in1tiate changed the title Handle "DC" packets, don't show disconnection popup on kick/ban Consolidate kick and kickban packets into one (more versatile) handler Apr 30, 2020
@stonedDiscord
Copy link
Member

stonedDiscord commented Apr 30, 2020

this is not a new feature but cleaning up

@oldmud0
Copy link
Member

oldmud0 commented May 1, 2020

Well, now it's not a new feature anymore.

@in1tiate
Copy link
Contributor Author

in1tiate commented May 2, 2020

Marking as draft, I have some additional plans for this

@in1tiate in1tiate marked this pull request as draft May 2, 2020
@in1tiate
Copy link
Contributor Author

in1tiate commented Sep 7, 2020

Dead PR, closing.

@in1tiate in1tiate closed this Sep 7, 2020
@in1tiate in1tiate deleted the tsu-dcinfo branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.