Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConsolidate kick and kickban packets into one (more versatile) handler #152
Conversation
CR likely stands for "CentsRaidensnake." Like the Case Cafe mega-merge before it, this was not a clean merge, and it had to be split up into two parts: the actual changes, and the attempt it made to reformat the entire code via clang-format. This branch had a complicated set of changes that would be difficult to describe in this commit message. It would be better described in a proper changelog.
Indentation fixed to 2 spaces per tab. Braces set to Stroustrup style. Lines reflow at 80 characters. One-line method bodies are on the same line as the signature. Space always after `//`. No indentation on preprocessor macros. Includes are sorted lexicographically. If you don't want to see this commit on blames, use the hidden whitespace option on GitHub, or use `-w` in git-blame.
"shownames" isn't a word, and what does "Custom shownames" even mean anyway? "Show custom IC names" should do a better job at explaining what this option does.
As far as I know checkbox is more common
As far as I know checkbox is more popular than tickbox, on Wikipedia for example it's called checkbox. And some spell checkers will highlight tickbox as a typo, but not checkbox.
No need for two exclamations
Thanks Initiate for actually fixing this
Without an option to change it users will complain Thanks Initiate for telling me how to change this
I didn't format anything tho that is at the end
Did you know you could scale the iclog with ctrl + mouse wheel?
…into 2.7-rc
|
No more features allowed in 2.7-rc. Moved base to master. Wait for merge. Also, the |
|
this is not a new feature but cleaning up |
|
Well, now it's not a new feature anymore. |
|
Marking as draft, I have some additional plans for this |
|
Dead PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
in1tiate commentedApr 29, 2020
sister PR to AttorneyOnline/tsuserver3#100