Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3: Signature verification throws an error if the transaction was not signed properly #11885

Open
jstarry opened this issue Aug 28, 2020 · 0 comments
Milestone

Comments

@jstarry
Copy link
Member

@jstarry jstarry commented Aug 28, 2020

Problem

When a transaction is compiled, it creates entries in its signatures array for the public keys that it expects signatures from. If any of those signatures are missing, a call to verifySignatures will throw an error because it tries to pass a null signature into nacl.sign.detached.verify.

Proposed Solution

Handle this case better by throwing an understandable error message explaining that the transaction was not signed by a particular public key

@jstarry jstarry added this to the v1.4.0 milestone Aug 28, 2020
@jstarry jstarry changed the title [web3] Signature verification throws an error if the transaction was not signed properly web3: Signature verification throws an error if the transaction was not signed properly Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.