Restoring snapshot without /repositories/info to cluster fails with permission denied #483

djdefi · 2019-04-06T23:06:43Z

This section of the restore code appears to fail when restoring to a cluster, if the snapshot does not contain /repositories/info:

backup-utils/share/github-backup-utils/ghe-restore-repositories

Lines 172 to 184 in 97e407b

    
           bm_start "$(basename $0) - Updating repository info data" 
        
           if [ -d $GHE_DATA_DIR/$GHE_RESTORE_SNAPSHOT/repositories/info ]; then 
        
             ghe_verbose "* Transferring repository info data" 
        
             for hostname in $hostnames; do 
        
               if ! ghe-rsync -av --delete \ 
        
                 -e "ssh -q $opts -p $port $ssh_config_file_opt -l $user" \ 
        
                 --rsync-path="sudo -u git rsync" \ 
        
                 "$GHE_DATA_DIR/$GHE_RESTORE_SNAPSHOT/repositories/info/" \ 
        
                 "$hostname:$GHE_REMOTE_DATA_USER_DIR/repositories/info" 1>&3; then 
        
                 echo "Error restoring /data/repositories/info to $hostname" 1>&2 
        
               fi 
        
             done 
        
           else

The glob doesn't appear to work:

$ sudo -u git ls -lah /data/repositories/info/*
ls: cannot access /data/repositories/info/*: No such file or directory

$ echo $?
0

$ sudo ls -lah /data/repositories/info
total 16K
drwxr-xr-x  2 git  git  4.0K Apr  2 03:38 .
drwx------ 19 git  git  4.0K Apr  2 03:35 ..
-rw-r--r--  1 git  git    21 Apr  2 03:34 nw-layout
-rw-r--r--  1 root root   11 Apr  2 03:38 svn-v4-upgraded```

Do we really want to remove these files, or is this left over code from supporting GitHub Enterprise 11.x backup / restore?

cc @jatoben

github / backup-utils

Restoring snapshot without /repositories/info to cluster fails with permission denied #483

Restoring snapshot without /repositories/info to cluster fails with permission denied #483

djdefi commented Apr 6, 2019

github / backup-utils

Join GitHub today

GitHub is where the world builds software

Restoring snapshot without /repositories/info to cluster fails with permission denied #483

Restoring snapshot without /repositories/info to cluster fails with permission denied #483

Comments

djdefi commented Apr 6, 2019

Essential cookies

Always active

Analytics cookies