Bump to latest version of golang.org/x/tools#314
Conversation
| require ( | ||
| golang.org/x/mod v0.2.0 | ||
| golang.org/x/tools v0.0.0-20200302225559-9b52d559c609 | ||
| github.com/ChrisTrenkamp/goxpath v0.0.0-20190607011252-c5096ec8773d |
There was a problem hiding this comment.
This seems strange to me.
Why is goxpath included here?
In my XPath PR I included tests for many different libraries, so there should probably either be more XPath libraries or none, I guess?
There was a problem hiding this comment.
Appears to be an indirect dependency of golang.org/x/tools, not something I directly introduced
There was a problem hiding this comment.
Ok, I was worried I messed something up in my PR^^
In earlier versions of golang/x/tools these would be omitted entirely; now they can result in ast.File structures whose ast.Package field is zero (NoPos), and in my experience these contain no information in their other fields either.
|
Found the cause of the new segfaults -- the way files without a |
These weren't previously reported as part of the comment text, but are as of the latest version of golang.org/x/tools
|
@github/codeql-go LGTM eval shows this fixes 27 projects with go-1.15. After this there are 11 post-go-1.13 regressions left, with no common cause except 5 projects complaining about a malformed go.mod containing a line like |
3 participants
This fixes 23 projects that currently fail to build with go-1.15, but introduces a new segfault with 23 other projects:
Will investigate the cause of the segfault -- golang.org/x/tools is released very frequently, so this may just be a question of finding a particular build that exhibits neither problem.