Skip to content

/ oppia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prod validators to be split into individual validators #10415

Open
ankita240796 opened this issue Aug 22, 2020 · 30 comments
Open

Refactor prod validators to be split into individual validators #10415

ankita240796 opened this issue Aug 22, 2020 · 30 comments
Labels
Hacktoberfest good first issue gracehopperOSD
Projects
Data handling

Comments

@ankita240796
Copy link
Member

@ankita240796 ankita240796 commented Aug 22, 2020 •
edited by vojtechjelinek

Refactor prod_validators.py such that there is one validator module per model module in core/storage/.

List of model categories

Steps to refactor

  • Extract all the validators related to a given model type for example activity into a new file named as <model-type>_validators.py for example activity_validators.py from prod_validators.py. Make sure you name the validators file exactly as <folder-name-in-above-list>_validators.py
  • Extract all the test related to the model type from prod_validators_test.py to <model-type>_validators_test.py.
  • Clean up the unused imports from the new validators file and existing prod validators file.
  • Clean up the unused variables from the new validators file and existing prod validators file.
  • Fix the file overview to have the correct explanation and copyright year.

Example PR: #10416 #10360
@ankita240796
Copy link
Member Author

@ankita240796 ankita240796 commented Aug 22, 2020

@vojtechjelinek PTAL to confirm if this looks fine, Thanks!
@ankita240796 ankita240796 mentioned this issue Aug 24, 2020
Merged
4 of 4 tasks complete
ankita240796 added a commit that referenced this issue Aug 24, 2020
@ankita240796
Fixes part of #10415: Refactor activity validators (#10416)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cdcd030 
* Refactor activity validators

* Fix import

* Fix import

* Address review comments

* Fix braces
@DubeySandeep
Copy link
Member

@DubeySandeep DubeySandeep commented Sep 19, 2020

Assigning @savithakj to the opportunity module. (As per offline discussion.)
@savithakj savithakj mentioned this issue Sep 20, 2020
Merged
4 of 4 tasks complete
@vojtechjelinek vojtechjelinek added this to To do in Data handling Sep 23, 2020
seanlip pushed a commit that referenced this issue Sep 26, 2020
@savithakj
Fixes part of #10415: Refactor opportunity validators (#10735)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13d3208 
* refractored oppportunity validators

* fixed linter error

* refractored oppportunity validators

* fixed linter error

* removed collection_models

* reverting local linter error based changes

* reverted local linter error changes
@rlhouser
Copy link

@rlhouser rlhouser commented Sep 30, 2020

I would like to try to work on the classifier model; thanks. @ankita240796, @DubeySandeep
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Sep 30, 2020

@rlhouser I have assigned you
@sunny1401
Copy link

@sunny1401 sunny1401 commented Sep 30, 2020

I would like to try to work on the recommendations model. Thanks @ankita240796 @DubeySandeep
@vojtechjelinek
Copy link
Member

@vojtechjelinek vojtechjelinek commented Oct 1, 2020

@sunny1401 I have assigned you.
@vcamari2-bit
Copy link

@vcamari2-bit vcamari2-bit commented Oct 1, 2020

Can I try to work on audit?
@EricZLou
Copy link
Collaborator

@EricZLou EricZLou commented Oct 1, 2020

@sf11047 absolutely! Assigned the task to you. Let us know if you have any questions!
@EricZLou
Copy link
Collaborator

@EricZLou EricZLou commented Oct 1, 2020

@vcamari2-bit sorry! Audit just got assigned -- do you want to take a stab at one of the other modules?
@vcamari2-bit
Copy link

@vcamari2-bit vcamari2-bit commented Oct 1, 2020

Sure. How about config or email?
@dchen97
Copy link
Collaborator

@dchen97 dchen97 commented Oct 1, 2020 •
edited

@vcamari2-bit - Go for config!
@shujingl-2020
Copy link

@shujingl-2020 shujingl-2020 commented Oct 1, 2020 •
edited

Hi! I would like to work on the job module! As a part of GHC OSD
@EricZLou
Copy link
Collaborator

@EricZLou EricZLou commented Oct 1, 2020

@shujingl-2020 awesome! Assigning you to the job module. DM me with questions!
@pseyla
Copy link

@pseyla pseyla commented Oct 1, 2020

Hi! Could I work on the email module?
@EricZLou
Copy link
Collaborator

@EricZLou EricZLou commented Oct 1, 2020

@pseyla absolutely!
@Salset
Copy link

@Salset Salset commented Oct 1, 2020

Hey, can I work on the exploration module as part of GHC OSD?
@kiranmayee-dobbali
Copy link

@kiranmayee-dobbali kiranmayee-dobbali commented Oct 1, 2020

Hey, Can I get feedback module? I am a part of GHC OSD.
@ajin46
Copy link

@ajin46 ajin46 commented Oct 1, 2020

Hi, can I work on Suggestion as a part of GHC OSD?
@EricZLou
Copy link
Collaborator

@EricZLou EricZLou commented Oct 1, 2020

@Salset @kiranmayee-dobbali @ajin46 yes yes and yes! Let us know if you have any questions
@rlhouser rlhouser mentioned this issue Oct 1, 2020
Open
4 of 4 tasks complete
vcamari2-bit added a commit to vcamari2-bit/oppia that referenced this issue Oct 1, 2020
@vcamari2-bit
Update and rename prod_validators.py to prod_config_validator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7a68c5b 
Overview

    This PR fixes or fixes part of oppia#10415.
    This PR does the following: Refactors config classifier validator to a separate file.
vcamari2-bit added a commit to vcamari2-bit/oppia that referenced this issue Oct 1, 2020
@vcamari2-bit
Update and rename prod_validators.py to prod_config_validator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
1d7129f 
Overview

    This PR fixes or fixes part of oppia#10415.
    This PR does the following: Refactors config classifier validator to a separate file.
@kiranmayee-dobbali kiranmayee-dobbali mentioned this issue Oct 1, 2020
Open
4 of 4 tasks complete
@pseyla pseyla mentioned this issue Oct 2, 2020
Closed
4 of 4 tasks complete
@shujingl-2020 shujingl-2020 mentioned this issue Oct 2, 2020
Open
4 of 4 tasks complete
@sunny1401 sunny1401 mentioned this issue Oct 2, 2020
Open
4 of 4 tasks complete
This was referenced Oct 2, 2020
Closed
Open
@purvimisal
Copy link

@purvimisal purvimisal commented Oct 6, 2020

Hi, I'd like to work on the story model.
@sajalasati
Copy link
Member

@sajalasati sajalasati commented Oct 6, 2020 •
edited

@purvimisal I've assigned you to it! Let us know if you have any questions.
@sajalasati
Copy link
Member

@sajalasati sajalasati commented Oct 6, 2020

@ankita240796 I've assigned the skill model to myself.
@sajalasati sajalasati mentioned this issue Oct 8, 2020
Merged
4 of 4 tasks complete
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
9df68cf
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
6dafebc
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
7a89b4f
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
dcb4cd9
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
eb25f62
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
a515917
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators
2daf543
@purvimisal purvimisal mentioned this issue Oct 9, 2020
Closed
4 of 4 tasks complete
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 9, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators - modified
Loading status checks…
af5bb9d
@KhushiGangopadhyay
Copy link

@KhushiGangopadhyay KhushiGangopadhyay commented Oct 10, 2020

hello, i would like to work on collection module, can anyone assign me that
@sajalasati
Copy link
Member

@sajalasati sajalasati commented Oct 10, 2020

@KhushiGangopadhyay I've assigned you! Let us know if you have any questions.
@arora-ria
Copy link

@arora-ria arora-ria commented Oct 11, 2020

Hey, I would like to work on stats_model (statistics). Thank you!
@sajalasati
Copy link
Member

@sajalasati sajalasati commented Oct 12, 2020

@arora-ria I've assigned you! Let us know if you have any questions.
@MeetVys
Copy link

@MeetVys MeetVys commented Oct 12, 2020 •
edited

I would like to work on the improvements, if possible. @vojtechjelinek
@MeetVys MeetVys mentioned this issue Oct 13, 2020
Open
4 of 4 tasks complete
@vojtechjelinek vojtechjelinek moved this from TODO (critical) to TODO (improvement/feature) in Data handling Oct 13, 2020
@vojtechjelinek vojtechjelinek moved this from TODO (improvement/feature) to TODO (keep for new contributors) in Data handling Oct 13, 2020
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 13, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators - modified
b0dbbf8
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 13, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators - fixing checks
8ea8885
purvimisal added a commit to purvimisal/oppia that referenced this issue Oct 13, 2020
@purvimisal
Fixes part of oppia#10415: Refactor story validators - fixing checks
Loading status checks…
f5f3521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest good first issue gracehopperOSD
Projects
Data handling
  
TODO (for new contributors)
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.