Mini changes pulled from #2146#2194
Merged
Merged
Conversation
youknowone
approved these changes
Sep 11, 2020
|
|
||
| #[pymethod(name = "__repr__")] | ||
| #[pymethod(magic)] | ||
| fn getitem(&self, idx: isize, vm: &VirtualMachine) -> PyResult { |
Member
There was a problem hiding this comment.
oh.. it even didn't have getitem
Member
Author
There was a problem hiding this comment.
Yeah, I had the same reaction 😁
|
|
||
| impl_into_pyobject_int!(isize i8 i16 i32 i64 usize u8 u16 u32 u64 BigInt); | ||
|
|
||
| pub fn try_to_primitive<'a, I>(i: &'a BigInt, vm: &VirtualMachine) -> PyResult<I> |
| Some(CFormatQuantity::FromValuesTuple) => match elements.next() { | ||
| Some(width_obj) => { | ||
| tuple_index += 1; | ||
| if !objtype::isinstance(&width_obj, &vm.ctx.types.int_type) { |
Member
There was a problem hiding this comment.
swapping if and else would make else block a lot cleaner.
but it seems it is not part of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.