Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNA codons decoder #354

Open
lukasgabriel opened this issue Sep 5, 2020 · 8 comments
Open

Add DNA codons decoder #354

lukasgabriel opened this issue Sep 5, 2020 · 8 comments

Comments

@lukasgabriel lukasgabriel added this to To do in Features via automation Sep 5, 2020
@issue-label-bot
Copy link

@issue-label-bot issue-label-bot bot commented Sep 5, 2020

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@lukasgabriel lukasgabriel moved this from To do to To do - Ciphers & Decoders in Features Sep 5, 2020
@MikeMerz
Copy link

@MikeMerz MikeMerz commented Sep 6, 2020

Hi,I'm new to contributing, is it possible to try this one?

@bee-san
Copy link
Member

@bee-san bee-san commented Sep 6, 2020

Hi,I'm new to contributing, is it possible to try this one?

Hey @MikeMerz !!

Welcome to Ciphey! And if you're new to contributing, what a great project to contribute to 😉

This is our guide on adding new things to Ciphey:

https://github.com/Ciphey/Ciphey/wiki/Adding-your-own-ciphers

You'll want to add a decoder for this.

I would suggest getting a function working outside of Ciphey first, and then importing it into Ciphey when it's ready to be added :)

if you have to have a dictionary or table of letters or an alphabet, please let us know. We can add it to CipheyDists which will be much easier for you and I to deal with 😄

We have a Discord where we can provide direct, as-soon-as-possible support too:
https://discord.gg/KfyRUWw

If you have any questions or need support please don't be afraid to let us know :) I have assigned this issue to you

@bee-san bee-san mentioned this issue Sep 6, 2020
12 of 34 tasks complete
@anantverma275
Copy link

@anantverma275 anantverma275 commented Sep 6, 2020

Hello all,
I am new to Open Source contributions, so could you help me with what to do next?

I have already:

  1. cloned this repository on my system
  2. added DNAtoBinary.py file in ciphey/basemods/Decoder
  3. configured init.py file accordingly by adding this module into the import list.

Also, could you tell me how do I test this module using the ciphey package?

Thank you!

@MikeMerz
Copy link

@MikeMerz MikeMerz commented Sep 7, 2020

Hey @bee-san ,
Thanks for the welcoming massage :)
I have written a class for the decoding according to the first comment, using a dictionary for the four letters of the DNA,
so after running some test I just commit the changes?

@bee-san
Copy link
Member

@bee-san bee-san commented Sep 7, 2020

Hey @bee-san ,
Thanks for the welcoming massage :)
I have written a class for the decoding according to the first comment, using a dictionary for the four letters of the DNA,
so after running some test I just commit the changes?

Hey! Very sorry, but someone got there first. This is especially annoying, as I assigned you to this issue and they must have ignored it :( #363

I added another issue that I believe is quite easy to implement, do you want me to assign you to this instead? :) It's URL decoding

#368

@SkeletalDemise
Copy link
Contributor

@SkeletalDemise SkeletalDemise commented Sep 7, 2020

Hello, unfortunately this issue title is misleading and we are not looking for a DNA to Binary decoder. We are wanting a DNA codons decoder similar to this https://www.dcode.fr/codons-genetic-code
I'll fix it so it's not misleading and add more resources.

Additionally, I have now taken over this issue/decoder with additional support from @anantverma275 in the Discord. I have already created a table mapping the various DNA codons to letters. I suggest you pick another encoding or cipher to implement from one of the issues, or you can work on the one that @bee-san suggested. Thank you.

@SkeletalDemise SkeletalDemise changed the title Add 'DNA-to-binary' decoder Add DNA codons decoder Sep 7, 2020
@MikeMerz
Copy link

@MikeMerz MikeMerz commented Sep 7, 2020

Hey @bee-san ,
Thanks for the welcoming massage :)
I have written a class for the decoding according to the first comment, using a dictionary for the four letters of the DNA,
so after running some test I just commit the changes?

Hey! Very sorry, but someone got there first. This is especially annoying, as I assigned you to this issue and they must have ignored it :( #363

I added another issue that I believe is quite easy to implement, do you want me to assign you to this instead? :) It's URL decoding

#368

Ye sure I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Features
  
To do - Ciphers & Decoders
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.