Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .gitignore file. #50

Merged
merged 2 commits into from Apr 7, 2017
Merged

Added .gitignore file. #50

merged 2 commits into from Apr 7, 2017

Conversation

@saurabhkpatel
Copy link
Contributor

@saurabhkpatel saurabhkpatel commented Apr 6, 2017

Used the standard one: https://github.com/github/gitignore/blob/master/Python.gitignore
Added support for intelliJ/pycharm .idea folder.

@dbieber
Copy link
Member

@dbieber dbieber commented Apr 7, 2017

Let's check this in. Can you add a newline at the end first, please?

Some commentary:

  • I want to avoid having every contributor adding their own ignore rules to google/python-fire's .gitignore file. See the section on explicit repository excludes for how to additionally ignore files that only apply to you.
  • google/python-fire's .gitignore file should only have rules that apply to a very large number of developers. Using GitHub's provided Python.gitignore file sounds good to me. I'm OK w/ adding .idea at the end since PyCharm is common (can you fix the capitalization btw?), though want to be careful not to set a precedent of modifying the .gitignore for individual developers.
@dbieber dbieber merged commit 8ea4229 into google:master Apr 7, 2017
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saurabhkpatel saurabhkpatel deleted the saurabhkpatel:add_gitignore branch Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.