Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deque's Axe Plugin catches WCAG violations in base storybook boilerplate #11062

Open
angel1199410 opened this issue Jun 5, 2020 · 4 comments
Open

Comments

@angel1199410
Copy link

@angel1199410 angel1199410 commented Jun 5, 2020

Describe the bug
When running Deque's Axe plugin on a webpage, I found multiple accessibility errors with the Storybook boilerplate.

To Reproduce
Steps to reproduce the behavior:

  1. Load and run the Storybook boilerplate with generic components - Button with Text and Button with Emoji.
  2. Download Deque's Axe Google Chrome plugin
  3. Run the plugin on the running boilerplate.
  4. See accessibility errors with exact selectors where issues were found.

Expected behavior
Axe should return no errors.

System:
Binaries:
Node: 10.15.3
npm: 6.4.1
npmPackages:
@storybook/cli: 5.3.17
@storybook/html: 5.3.17

Additional context
Some issues have already been opened with solutions to the problems within Storybook's boilerplate. I've linked to those, where applicable. I have also linked directly to Deque's documentation on the required fixes for each accessibility defect.

  1. Page must have means to bypass repeated blocks.

    • Previously-opened issue with this same problem: #4667
  2. Page must have one main landmark.

  3. Page must contain a level-one heading.

  4. All page content must be contained by landmarks.

  5. Text Elements must have sufficient color contrast against the background

    • Previously-opened issue with this same problem: #8935

Running the plugin before every release will help validate that no accessibility bugs exist and that consumers are compliant when building out storybook applications. Thank you for your time!

@shilman
Copy link
Member

@shilman shilman commented Jun 6, 2020

@yannbf @tooppaaa i know you've got a lot on your plate with the CLI overhaul but FYI....

@stale
Copy link

@stale stale bot commented Jul 18, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 18, 2020
@stale
Copy link

@stale stale bot commented Aug 22, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this Aug 22, 2020
@shilman shilman reopened this Aug 22, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Aug 22, 2020

Automention: Hey @Keraito, you've been tagged! Can you give a hand here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.