fire.Fire(func) means that `func` cannot return an empty dict #4

ubershmekel · 2017-03-04T06:40:15Z

import fire

def x():
    return {}

fire.Fire(x)

Will cause this stack trace:

Traceback (most recent call last):
  File "E:/1stuff/Dropbox/dev/python/testfire/testing.py", line 7, in <module>
    z = fire.Fire(x)
  File "C:\Users\yuv\AppData\Local\Programs\Python\Python36-32\lib\site-packages\fire\core.py", line 145, in Fire
    _PrintResult(component_trace, verbose=component_trace.verbose)
  File "C:\Users\yuv\AppData\Local\Programs\Python\Python36-32\lib\site-packages\fire\core.py", line 181, in _PrintResult
    print(_DictAsString(result, verbose))
  File "C:\Users\yuv\AppData\Local\Programs\Python\Python36-32\lib\site-packages\fire\core.py", line 201, in _DictAsString
    len(str(key)) for key in result.keys()
ValueError: max() arg is an empty sequence

This should handle google#4

guoruibiao · 2017-03-04T10:38:50Z

python-fire is awesome cool.

dbieber · 2017-03-05T05:59:16Z

@ubershmekel Thanks for finding and fixing this bug! I'll respond to the pull request later in the week.

* Fix for empty dictionary print outs This should handle #4 * pep8 prefers `if not seq` over `len == 0` * Use single quotes

ubershmekel added a commit to ubershmekel/python-fire that referenced this issue Mar 4, 2017

Fix for empty dictionary print outs

e1f196b

This should handle google#4

ubershmekel mentioned this issue Mar 4, 2017

Fix for empty dictionary print outs #5

Merged

dbieber added the bug label Mar 4, 2017

dbieber added a commit that referenced this issue Mar 6, 2017

Allow Fire to serialize empty dictionaries (#5)

Loading status checks…

59d9095

* Fix for empty dictionary print outs This should handle #4 * pep8 prefers `if not seq` over `len == 0` * Use single quotes

dbieber closed this Mar 6, 2017

google / python-fire

fire.Fire(func) means that `func` cannot return an empty dict #4

fire.Fire(func) means that `func` cannot return an empty dict #4

ubershmekel commented Mar 4, 2017

guoruibiao commented Mar 4, 2017

dbieber commented Mar 5, 2017

google / python-fire

Join GitHub today

fire.Fire(func) means that `func` cannot return an empty dict #4

fire.Fire(func) means that `func` cannot return an empty dict #4

Comments

ubershmekel commented Mar 4, 2017

guoruibiao commented Mar 4, 2017

dbieber commented Mar 5, 2017

Essential cookies

Always active

Analytics cookies