Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the buffer slots can be set with PyType_Spec with the unlimited … #22031

Merged
merged 1 commit into from Sep 2, 2020
Merged

Note the buffer slots can be set with PyType_Spec with the unlimited … #22031

merged 1 commit into from Sep 2, 2020

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Aug 31, 2020

…API.

alex
alex approved these changes Aug 31, 2020
alex
alex approved these changes Aug 31, 2020
Copy link
Member

@corona10 corona10 left a comment

@benjaminp Please rebase your branch, it will solve the docs failure.

@@ -239,6 +240,10 @@ The following functions and structs are used to create
(see :ref:`PyMemberDef <pymemberdef-offsets>`)
* :c:member:`~PyTypeObject.tp_vectorcall_offset`
(see :ref:`PyMemberDef <pymemberdef-offsets>`)

The following fields cannot be set using :c:type:`PyType_Spec` and
Copy link
Member

@alex alex Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this contain a versionchanged annotation?

@benjaminp benjaminp merged commit 700fa1b into python:master Sep 2, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 2, 2020

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@benjaminp benjaminp deleted the buffer-docs branch Sep 2, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2020
…API. (pythonGH-22031)

Follow up to f7c4e23.
(cherry picked from commit 700fa1b)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 2, 2020

GH-22052 is a backport of this pull request to the 3.9 branch.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants