Hello @zulip/server-markdown members, this issue was labeled with the "area: markdown" label, so you may want to check it out!

I'd like to work on this. Can someone guide me as to where I can get started?

Check out the Zulip developer documentation.

The relevant code seems to be:

@aero31aero can likely help investigate.

As @Gittenburg said, the bug is in L1233 above. The easiest fix here would be something like:

# replace title of link if 
def maybe_replace_link_title(found_url, title):
    (url, text) = found_url.result
    if text == url:
        found_url.family.child.text = title

This same bug should be present with vimeo links too.

For easier manual testing, just comment this check:

            if not self.md.url_embed_preview_enabled:
                continue

Slightly long term, do we really want to modify the original link text and not add the title to the preview like we do for our Twitter previews?

Yeah I think having the title above the preview would be better.

@zulipbot claim

Welcome to Zulip, @akshatdalton! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

I'd like to work on this. Could someone guide me to get started?

@zulipbot claim

@zulipbot claim

Hello @dynamoh, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it.

We look forward to your valuable contributions!

I see that this is already being worked on. Is there a slack channel I can join?

No, we use Zulip: https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html