Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oci-notify utility #85

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@guidotijskens
Copy link
Collaborator

guidotijskens commented Aug 18, 2020

updated oci-notify code with suggestions from Frank Deng and Joe Kennedy, limit the length of the subject, limit the size of the body to 10 chunks of 64KB; looks for location of the private key in the config file iso hardcode directory
.
run on OL7 and OL8

@guidotijskens guidotijskens requested review from ejannett and samiam69 Aug 18, 2020

.B oci-notify
command writes log and error messages to the logfile
.B /var/log/oci-notify.log

This comment has been minimized.

@ejannett

ejannett Aug 20, 2020

Member

What about having a common approach for all oci-utils utilities ? is it debug messages or messages useful for end users ?

expects the configuration files by default in
.B /etc/oci-utils
but this is overruled by the environment variable
.B OCI_CONFIG_DIR.

This comment has been minimized.

@ejannett

ejannett Aug 20, 2020

Member

Is it a requirement ? This is not aligned with other oci-utils commands

Copy link
Member

ejannett left a comment

Hi,
Why not having used the OCI sdk directly rather than writing a wrapper around 'oci' cli ?

@guidotijskens
Copy link
Collaborator Author

guidotijskens commented Aug 21, 2020

manu, this is a quick adaptation of the al-notify bash script; at the time of the request there was time pressure; now it will not be released very soon, will be ported to python and using sdk;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.