Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: correct --frozen-intrinsics override fix #35041

Merged
merged 1 commit into from Sep 6, 2020

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Sep 3, 2020

Resolves #35035, bringing in the same patch from endojs/endo#409 with the associated test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 4, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 5, 2020

bmeck
bmeck approved these changes Sep 5, 2020
@addaleax addaleax added the author ready label Sep 5, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 5, 2020

Trott
Trott approved these changes Sep 6, 2020
@Trott Trott force-pushed the correct-override-fix branch from e8af3c7 to 04865cf Compare Sep 6, 2020
@Trott
Copy link
Member

@Trott Trott commented Sep 6, 2020

Landed in 04865cf

@Trott Trott merged commit 04865cf into nodejs:master Sep 6, 2020
23 checks passed
PR-URL: nodejs#35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau added a commit that referenced this issue Sep 7, 2020
PR-URL: #35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau added a commit that referenced this issue Sep 7, 2020
PR-URL: #35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
PR-URL: #35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
PR-URL: #35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi added a commit to joesepi/node that referenced this issue Jan 8, 2021
PR-URL: nodejs#35041
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants