Merged
Conversation
coolreader18
force-pushed
the
coolreader18/windows-binaryio
branch
2 times, most recently
from
fef1528 to
f45a8ce
Compare
| settings.initialization_parameter = InitParameter::InitializeInternal; | ||
| } | ||
|
|
||
| // don't translate newlines (\r\n <=> \n) |
There was a problem hiding this comment.
Does CPython do this? My concern is that as this will have process wide effects, this may have unintended consequences for programs that embed RustPython.
Member
Author
There was a problem hiding this comment.
this may have unintended consequences for programs that embed RustPython.
That's why I moved it from vm::initialize to main, it should only happen for the actual rustpython binary.
Does CPython do this?
coolreader18
force-pushed
the
coolreader18/windows-binaryio
branch
from
f45a8ce to
717784d
Compare
Member
Author
|
Ahh, I think I found the problem -- our TextIOWrapper doesn't translate newlines. Maybe. Like when the script process prints to stdout, it prints |
coolreader18
force-pushed
the
coolreader18/windows-binaryio
branch
from
197a887 to
5594660
Compare
BenLewis-Seequent
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.