Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd width awareness to fix wrapping of strings with full width chars #839
Conversation
|
Could you please rebase this PR? |
|
Just noticed a bug with this; maybe don't accept yet.
|
|
That bug I mentioned ^^ is fixed now, as of that last push. Now, if wcswidth throws an error, we catch it and use the old display_linize. I also added some relevant tests. |
- update display_linize to use curtsies 3.0 width functionality - correct cursor positioning on wrapped fullwidth chars by adding new method - add test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rybarczykj commentedAug 5, 2020
This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back
Wrapping strings with fullwidth chars
Here's the same string being typed before and after width awareness:
New method to fix cursor position:
When we put a 2-column character at the end of the line where there's only 1 column of room, curtsies adds a padding character (space) so we can kick it down to the line below. Therefore, in order to get the right cursor position, I had to add a method that determines how many padding chars there are (
number_of_padding_chars_on_current_cursor_line).Note on this method: Right now, to determine the amount of padding, it calls
display_linize, doubling the amount of times we call that function. It's definitely possible to keep track of this as a variable in the repl class instead, or to do some changes other to ensure less redundant work is done. Feedback appreciated.Runtime
One of the barriers stopping us from implementing this before was runtime . I did not find any noticeable difference when pasting, printing, or moving my cursor around large strings.