Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 support #819

Open
sebastinas opened this issue Jul 11, 2020 · 6 comments
Open

Dropping Python 2 support #819

sebastinas opened this issue Jul 11, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@sebastinas
Copy link
Contributor

@sebastinas sebastinas commented Jul 11, 2020

As Python 2.7 has now reached its end of life, I think it's time to drop all the special cases to support it. I propose to have 0.20 as last version with Python 2.7 support. @supakeen, @thomasballinger, what do you think?

@sebastinas sebastinas added the proposal label Jul 11, 2020
@sebastinas sebastinas added this to the release-0.21 milestone Jul 11, 2020
@sebastinas sebastinas self-assigned this Jul 11, 2020
@thomasballinger
Copy link
Member

@thomasballinger thomasballinger commented Jul 11, 2020

That sounds good to me!

For clarify for others reading (and to confirm) I assume we would not be yanking the old releases or anything, so installing bpython in Python 2 would continue to work; it just wouldn't get any updates.

@supakeen
Copy link
Member

@supakeen supakeen commented Jul 11, 2020

I'm +1 for dropping support (as I added warnings in 0.19) however I might be wary of dropping it so 'quickly'?

Do you propose removing all the special cases or to not pay attention to them anymore for 0.21?

@thomasballinger Yea we won't yank old releases :)

@thomasballinger
Copy link
Member

@thomasballinger thomasballinger commented Jul 12, 2020

It doesn't feel too quick to me, if there were a show-stopping bug we could do a point release. (thanks for adding those warnings too!)

@supakeen
Copy link
Member

@supakeen supakeen commented Jul 12, 2020

Then I agree on the timeframe; @sebastinas did you want to remove all the if py3 stuff and make it the default or not pay attention to them moving forwards?

@sebastinas
Copy link
Contributor Author

@sebastinas sebastinas commented Jul 13, 2020

I actually want to remove all the if py3 code in 0.21. Leaving them in the code base would give the false impression that we still care about Python 2 after we dropped support for it.

Considering how often we prepare releases, 0.21 would only happen sometime sometime in 2021. This will give people some time to move on.

@supakeen
Copy link
Member

@supakeen supakeen commented Jul 13, 2020

Yea that makes sense; probably 0.20 somewhere this year if I get to my assigned bugs then 0.21 somewhere first half of next year. I'd love to remove as much as possible in that release (see also the frontends ticket in #820 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.