Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Windows Python2 compatibility #601

Merged
merged 1 commit into from Feb 18, 2016
Merged

Conversation

@adityagupta679
Copy link

adityagupta679 commented Jan 25, 2016

It breaks the code when using on windows python2

unsupported operand type | 'list' and 'list': python 2.7

Aditya Gupta Aditya Gupta
unsupported operand type | list and list: python 2.7
@thomasballinger
Copy link
Member

thomasballinger commented Jan 25, 2016

Introduced by #597

I don't know how big the Windows userbase is but this is probably enough to prompt a 15.1 soon.

@adityagupta679
Copy link
Author

adityagupta679 commented Jan 25, 2016

Yes , also while we are on it , I think we need to modify the "contributing" documentation for windows developers .

@thomasballinger
Copy link
Member

thomasballinger commented Jan 25, 2016

Cool, a separate PR for that would be great.

@adityagupta679
Copy link
Author

adityagupta679 commented Jan 25, 2016

I will get to it . I guess i will have to modify the contributing.rst file .

sebastinas added a commit that referenced this pull request Feb 18, 2016
Fixing Windows Python2 compatibility
@sebastinas sebastinas merged commit b50250a into bpython:master Feb 18, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.