Skip to content

/ electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setZoomLevel updates multiple windows' zoom level #24505

Open
Jokerwolf opened this issue Jul 10, 2020 · 4 comments
Open

setZoomLevel updates multiple windows' zoom level #24505

Jokerwolf opened this issue Jul 10, 2020 · 4 comments
Labels
10-x-y 8-x-y 9-x-y documentation 📓 good first issue platform/all
Projects
10-x-y Issues

Comments

@Jokerwolf
Copy link

@Jokerwolf Jokerwolf commented Jul 10, 2020 •
edited by alexeykuzmin

I'm calling set zoom level on a particular window from the main process. I have another window opened. Both windows change their zoom level. (see gist for repro).

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 8.3.4
    • 9.0.2
    • 10.0.0-beta.4
  • Operating System:
    • Windows 10 (10.0.19041)

Expected Behavior

I'd expect only the window on which setZoomLevel was called to change it's zoom

Actual Behavior

Both windows change their zoom level

To Reproduce

Gist: https://gist.github.com/Jokerwolf/da2f6b00566c1ac5f3f37f675625fe16

Additional Information

I've found a closed issue #16018
@sofianguy sofianguy added this to Unsorted Issues in 10-x-y Jul 13, 2020
@jkleinsc jkleinsc moved this from Unsorted Issues to Does Not Block Stable in 10-x-y Jul 15, 2020
@codebytere
Copy link
Member

@codebytere codebytere commented Jul 16, 2020 •
edited

This is because zoom policy at the Chromium level is same-origin, meaning that the zoom level for a specific domain propagates across all instances of windows with the same domain e.g. https://microsoft.com. Changing one of the URLs will make zoom work per-window again - we can add docs to clarify this.
@michael-hamilton
Copy link
Contributor

@michael-hamilton michael-hamilton commented Jul 22, 2020

I can add docs for this one and submit a PR
@alexeykuzmin alexeykuzmin added this to Backlog / Unsorted in Issues Jul 24, 2020
@ketulrudani
Copy link

@ketulrudani ketulrudani commented Jul 26, 2020

Can I work on this issue?
@codebytere
Copy link
Member

@codebytere codebytere commented Jul 26, 2020 •
edited

Sure! Anyone is free to open a PR :) Essentially we just want to note what i said above in the documentation for that method.
@ckerr ckerr moved this from Backlog / Unsorted to Unsorted in Issues Jul 28, 2020
@ckerr ckerr moved this from Unsorted to Prioritized in Issues Jul 28, 2020
@morgan-sam morgan-sam mentioned this issue Aug 24, 2020
Merged
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10-x-y 8-x-y 9-x-y documentation 📓 good first issue platform/all
Projects
10-x-y
Does Not Block Stable
Issues
Prioritized
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@jkleinsc @codebytere @sofianguy @Jokerwolf @michael-hamilton @ketulrudani
You can’t perform that action at this time.