Skip to content

/ certbot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create umask context manager #7992

Open
bmw opened this issue May 14, 2020 · 0 comments · May be fixed by #8226
Open

Create umask context manager #7992

bmw opened this issue May 14, 2020 · 0 comments · May be fixed by #8226
Labels
area: code health easy-fix good first issue priority: unplanned

Comments

@bmw
Copy link
Member

@bmw bmw commented May 14, 2020

In all of our current uses of os.umask or filesystem.umask, we always temporarily set it to a different value and then restore it using a try/finally block. I expect this pattern to continue.

Because of that, why don't we create a simple function in certbot.util that can be used as a context manager to set umask to a value and restore it to its previous value when exiting the with block?
Mercerenies added a commit to Mercerenies/certbot that referenced this issue May 26, 2020
@Mercerenies
os.umask context manager (certbot#7992)
9e1265a
Mercerenies added a commit to Mercerenies/certbot that referenced this issue May 26, 2020
@Mercerenies
os.umask context manager usage (certbot#7992)
52290f6
@Mercerenies Mercerenies mentioned this issue May 26, 2020
Open
0 of 2 tasks complete
Mercerenies added a commit to Mercerenies/certbot that referenced this issue May 27, 2020
@Mercerenies
Implemented certbot#7992 paradigm in http_01.py
41348c9
Mercerenies added a commit to Mercerenies/certbot that referenced this issue May 27, 2020
@Mercerenies
Implemented certbot#7992 paradigm in http_01.py (minor fix)
8b7adeb
Mercerenies added a commit to Mercerenies/certbot that referenced this issue May 27, 2020
@Mercerenies
Implemented certbot#7992 paradigm in http_01.py (minor fix)
a418cf4
@commit-dkp commit-dkp linked a pull request that will close this issue Aug 24, 2020
Open
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: code health easy-fix good first issue priority: unplanned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Create umask Context Manager
1 participant
@bmw
You can’t perform that action at this time.