Implement array math operator function#2175
Merged
Merged
Conversation
coolreader18
reviewed
Sep 1, 2020
Member
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Looks good! A few nits regarding use of PyObject::new but otherwise this is good to merge!
Comment on lines
+343
to
+349
| let obj = PyObject::new( | ||
| PyArray { | ||
| array: PyRwLock::new(sliced) | ||
| }, | ||
| PyArray::class(vm), | ||
| None | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| let obj = PyObject::new( | |
| PyArray { | |
| array: PyRwLock::new(sliced) | |
| }, | |
| PyArray::class(vm), | |
| None | |
| ); | |
| let obj = PyArray { | |
| array: PyRwLock::new(sliced) | |
| } | |
| .into_simple_object(vm); |
Comment on lines
+374
to
+380
| PyObject::new( | ||
| PyArray { | ||
| array: PyRwLock::new(sliced) | ||
| }, | ||
| PyArray::class(vm), | ||
| None | ||
| ) |
Member
There was a problem hiding this comment.
Same here, you can just do PyArray { .. }.into_simple_object(vm)
coolreader18
approved these changes
Sep 2, 2020
Member
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.