JS: Fix basic block synthetic return nodes#4130
Merged
codeql-ci merged 2 commits intogithub:mainfrom Sep 2, 2020
Merged
Conversation
asgerf
approved these changes
Sep 2, 2020
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
LGTM, thanks for following up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BasicBlockfor the exceptional and ordinary return of a function was the basicblock of the function itself.Its now been changed to be the basicblock for the function exit, which makes more sense.
Based on this comment in previous PR.
This doesn't look to break anything.