Skip to content

/ typing

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport `typing.OrderedDict` #679

Open
JelleZijlstra opened this issue Sep 20, 2019 · 1 comment
Open

Backport `typing.OrderedDict` #679

JelleZijlstra opened this issue Sep 20, 2019 · 1 comment

Comments

@JelleZijlstra
Copy link
Contributor

@JelleZijlstra JelleZijlstra commented Sep 20, 2019

As of 3.7, the standard library includes typing.OrderedDict, but it is missing from the backport in this repo.
@JelleZijlstra JelleZijlstra mentioned this issue Sep 20, 2019
Closed
@ilevkivskyi
Copy link
Collaborator

@ilevkivskyi ilevkivskyi commented Oct 15, 2019

This is a good point! I think it totally makes sense to add OrderedDict to the Python 2 version of typing. For Python 3 it should go to typing_extensions (similar to how it is done for DefaultDict). This can all be done in the same PR since typing_extensions live in this same repo.

Would you like to make a PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JelleZijlstra @ilevkivskyi
You can’t perform that action at this time.