Skip to content

build: cleanup .bazelrc file to no longer set unused flags#38124

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:patch-1
Closed

build: cleanup .bazelrc file to no longer set unused flags#38124
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:patch-1

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Jul 17, 2020

This option is no longer needed in Bazel and will be an error in the future.

devversion
devversion approved these changes Jul 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the commit message needs to be updated (to match our guidelines). Let me know, and I can push to this PR to green it up. Thanks Alex!

@devversion devversion added area: build & ci Related the build and CI infrastructure of the project action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 22, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Jul 22, 2020
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Jul 22, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    pending forbidden labels detected: PR action: cleanup
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Jul 22, 2020

@devversion why didn't we run commitlint as a husky pre-push hook? It would be a lot nicer to know that before running through all the CI

@josephperrott
Copy link
Copy Markdown
Member

josephperrott commented Jul 22, 2020

@alexeagle It should have run, did it fail to run for you?

josephperrott
josephperrott approved these changes Jul 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle @devversion
build: cleanup .bazelrc file to no longer set unused flags
5d41b51 
This option is no longer needed in Bazel and will be an error in the future
@devversion devversion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 3, 2020
@devversion devversion changed the title cleanup .bazelrc build: cleanup .bazelrc file to no longer set unused flags Aug 3, 2020
@alxhub alxhub closed this in e49b053 Aug 3, 2020
alxhub pushed a commit that referenced this pull request Aug 3, 2020
@alexeagle @alxhub
build: cleanup .bazelrc file to no longer set unused flags (#38124)
a91dd2e 
This option is no longer needed in Bazel and will be an error in the future

PR Close #38124
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 3, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 3, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@alexeagle @profanis
build: cleanup .bazelrc file to no longer set unused flags (angular#3 1�7
2fbcb58 
 1�78124)

This option is no longer needed in Bazel and will be an error in the future

PR Close angular#38124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeagle @josephperrott @devversion @googlebot