Skip to content

/ linuxboot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for a board should always clean out existing build/$BOARD/rom #23

Open
GanShun opened this issue May 4, 2018 · 1 comment
Open

Build for a board should always clean out existing build/$BOARD/rom #23

GanShun opened this issue May 4, 2018 · 1 comment
Labels
buildsystem enhancement

Comments

@GanShun
Copy link
Member

@GanShun GanShun commented May 4, 2018

If we have two different versions of a bios with different offsets of FVs, building with one rom first then the other will cause both folders to be left in the build/$BOARD/rom directory. This can mask problems as we end up building with the old FV rather than the new unintentionally if the Makefile isn't changed.

We can clean out the directory, or keep a record and warn when FV offsets have changed.
@osresearch
Copy link
Contributor

@osresearch osresearch commented May 4, 2018

That's not a bad plan. If $ROM ever changes we should probably rm -rf build/$(BOARD) as a first step to be sure that there are no leftovers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buildsystem enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@osresearch @GanShun
You can’t perform that action at this time.