chore(land): remove lite-ci checks #468
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 76.41% 82.56% +6.15%
==========================================
Files 27 34 +7
Lines 1717 1658 -59
==========================================
+ Hits 1312 1369 +57
+ Misses 405 289 -116
Continue to review full report at Codecov.
|
Lite CI is not used anymore, but some PRs got Lite-CI runs after some changes to the bot. node-core-utils Lite-CI parsing is not working though, therefore ncu will fail to land those PRs. Removing Lite-CI checks fix the issue and also reduces complexity. Fix: #466
|
codecov is complaining that we reduced coverage on the changes, which is n/a since this PR just removes code, so we should be good to land with some approvals :) |
| const cis = [...ciMap.keys()]; | ||
| return cis.find(ci => isFullCI(ci) || isLiteCI(ci)); | ||
| return cis.find(isFullCI); |
lundibundi
Aug 14, 2020
Member
Nit: could this be cis.some()?
Nit: could this be cis.some()?
mmarchini
Aug 14, 2020
Author
Member
Both work and both make sense, I don't think there's an upside to changing it
Both work and both make sense, I don't think there's an upside to changing it
mmarchini
merged commit 4b32ebc
into
nodejs:master
8 of 9 checks passed
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Lite CI is not used anymore, but some PRs got Lite-CI runs after some
changes to the bot. node-core-utils Lite-CI parsing is not working
though, therefore ncu will fail to land those PRs. Removing Lite-CI
checks fix the issue and also reduces complexity.
Fix: #466