Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pdf viewer template strings #25047

Merged
merged 2 commits into from Aug 20, 2020
Merged

fix: pdf viewer template strings #25047

merged 2 commits into from Aug 20, 2020

Conversation

codebytere
Copy link
Member

Backport of #24913.

See that PR for more details.

Notes: Fixed broken toolbar hover text in the PDF viewer.

@codebytere codebytere requested a review from a team August 19, 2020 22:45
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
@trop trop bot mentioned this pull request Aug 19, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Aug 19, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
@zcbenz
Copy link
Member

zcbenz commented Aug 20, 2020

There is a lint error:

$ node ./script/lint.js && npm run lint:clang-format && npm run lint:docs
shell/browser/extensions/electron_component_extension_resource_manager.cc:39:  Add #include <utility> for move  [build/include_what_you_use] [4]
Total errors found: 1

@codebytere codebytere merged commit 7fd8e6a into 10-x-y Aug 20, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 20, 2020

Release Notes Persisted

Fixed broken toolbar hover text in the PDF viewer.

@codebytere codebytere deleted the template-strings-10 branch August 20, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @MarshallOfSound