Skip to content

Use boolean instead of bitwise operators on bools#13506

Merged
iSazonov merged 2 commits intoPowerShell:masterfrom
xtqqczze:RCS1233
Sep 2, 2020
Merged

Use boolean instead of bitwise operators on bools#13506
iSazonov merged 2 commits intoPowerShell:masterfrom
xtqqczze:RCS1233

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

PR Summary

Autofix RCS1233: Use short-circuiting operator.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Aug 23, 2020
Copy link
Copy Markdown
Collaborator

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@xtqqczze
Copy link
Copy Markdown
Contributor Author

Before this PR, I didn't know bitwise operators could be used with bools 😄

@vexx32
Copy link
Copy Markdown
Collaborator

vexx32 commented Aug 23, 2020

You and me both 😂

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 24, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 1, 2020
@ghost
Copy link
Copy Markdown

ghost commented Sep 1, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from rjmholt September 1, 2020 04:39
@iSazonov iSazonov self-assigned this Sep 2, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Sep 2, 2020
@iSazonov iSazonov merged commit 4e21101 into PowerShell:master Sep 2, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Sep 2, 2020
@xtqqczze xtqqczze deleted the RCS1233 branch September 2, 2020 16:20
@ghost
Copy link
Copy Markdown

ghost commented Sep 8, 2020

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants