Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add changes metadata to TLS newSession event #34294

Closed
wants to merge 1 commit into from
Closed

doc: add changes metadata to TLS newSession event #34294

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jul 10, 2020

Not really relevant anymore, just for completeness.

Refs: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc tls labels Jul 10, 2020
lpinca
lpinca approved these changes Jul 10, 2020
View changes
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32390/

@tniessen tniessen added the author ready label Jul 17, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32395/

@github-actions github-actions bot mentioned this pull request Jul 18, 2020
Open
14 tasks
@github-actions github-actions bot mentioned this pull request Jul 19, 2020
Open
13 tasks
tniessen added a commit that referenced this issue Jul 19, 2020
@tniessen
doc: add changes metadata to TLS newSession event
9cbfaba 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen
Copy link
Member Author

@tniessen tniessen commented Jul 19, 2020

Landed in 9cbfaba, thank you for reviewing.

@tniessen tniessen closed this Jul 19, 2020
@tniessen tniessen removed the author ready label Jul 19, 2020
@github-actions github-actions bot mentioned this pull request Jul 20, 2020
Open
14 tasks
@github-actions github-actions bot mentioned this pull request Jul 21, 2020
Open
10 tasks
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Open
5 tasks
cjihrig added a commit that referenced this issue Jul 23, 2020
@tniessen @cjihrig
doc: add changes metadata to TLS newSession event
1f7194c 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 23, 2020
Open
6 tasks
MylesBorins added a commit that referenced this issue Jul 27, 2020
@tniessen @MylesBorins
doc: add changes metadata to TLS newSession event
1083073 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax added a commit that referenced this issue Sep 22, 2020
@tniessen @addaleax
doc: add changes metadata to TLS newSession event
692a23b 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
@tniessen @addaleax
doc: add changes metadata to TLS newSession event
88bd124 
Refs: #33715

PR-URL: #34294
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

Assignees
No one assigned
Labels
doc tls
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @nodejs-github-bot @jasnell @lpinca