Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Remove mentions of peps@python.org, update the process #1541

Merged
merged 2 commits into from Jul 29, 2020

Conversation

@encukou
Copy link
Member

@encukou encukou commented Jul 29, 2020

See discussion on Discourse.

This PR does a bit more than just replace the mailing list with the GitHub group: I meant to be closer to the current practice. Please amend and update this however you see fit.

  • peps@python.org is replaced by mentioning @python/pep-editors
  • Developers with write access are expected to handle their PRs
    themselves, and may mention @python/pep-editors if needed.
    This corresponds to the current situation (and means less
    work/responsibility for PEP editors, without a real downside).
  • Taking ownership of a PEP is done through GitHub rather than e-mail
  • A note about core devs managing their own PRs is repeated in
    "PEP Editor Responsibilities & Workflow": people might look there
    instead of reading all of "Submitting a PEP".
- peps@python.org is replaced by mentioning @python/pep-editors;
  python-checkins by the repository
- Devs with write access are encouraged to submit PRs rather than
  push commits directly.
- Developers with write access are expected to handle their PRs
  themselves, and may mention @python/pep-editors if needed.
  This corresponds to the current situation (and means less
  work/responsibility for PEP editors, without a real downside).
- Taking ownership of a PEP is done through GitHub rather than e-mail
- A note about core devs managing their own PRs is repeated in
  "PEP Editor Responsibilities & Workflow": people might look there
  instead of reading all of "Submitting a PEP".
@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Jul 29, 2020

+1 LGTM. I don't suppose it's possible to mention @pep-editors without the python/ in front of it?

@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Jul 29, 2020

Welp, it didn't turn into a link, so I'm presuming that, no, it's not possible. :)

pep-0001.txt Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@warsaw
warsaw approved these changes Jul 29, 2020
@warsaw
Copy link
Member

@warsaw warsaw commented Jul 29, 2020

Thank you for this update to PEP 1!

Copy link
Member

@gvanrossum gvanrossum left a comment

Fine with me. (When was I dropped from the list of PEP editors? I don't recall withdrawing, though I may simply have forgotten that I requested to be dropped in the aftermath of my BDFL retirement. In any case I've requested to be added to the team.)

@brettcannon brettcannon merged commit 593dc15 into python:master Jul 29, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@encukou encukou deleted the encukou:pep-editors-update branch Jul 29, 2020
AA-Turner added a commit to AA-Turner/peps that referenced this pull request Aug 15, 2020
…#1541)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
mnm678 added a commit to mnm678/peps that referenced this pull request Oct 22, 2020
…#1541)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
gaborbernat added a commit to gaborbernat/peps that referenced this pull request Dec 13, 2020
…#1541)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants