fix: #8567#8650
Closed
dimitrisdnr wants to merge 3 commits into
Closed
Conversation
Contributor
|
@dimitrisdnr on this one, like you've done for others, possible to add a sample in here https://github.com/NativeScript/NativeScript/tree/master/e2e/ui-tests-app/app/flexbox which uses |
Author
|
@NathanWalker Done. Thanks a lot for guiding me, I'll try to include samples from now on. :) |
Contributor
|
Excellent work @dimitrisdnr thank you! We'll queue this up with some others we're aiming for 👍 |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
@NathanaelA I created a new PR for this one here: #8798 . This PR can now be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When setting 'isPassThroughParentEnabled' property to FlexboxLayout, a exception is thrown.
What is the new behavior?
Property 'isPassThroughParentEnabled' will work for FlexboxLayout.
Fixes/Closes #8567 .