perf: faster view layout handling by farfromrefug · Pull Request #8255 · NativeScript/NativeScript

farfromrefug · 2020-01-17T14:34:13Z

reponed #7996 as draft

Related to this issue #7988

For now this PR only checks for auto in width or height. This is clearly not enough.
But the idea is to check if it is necessary to requestLayout on the parent. Most of the times it is not necessary.

In the case of a complex app the improvements is huge!. It makes apps using animations (not using {N} animation system which is too limited) far more snappier.

This is only a POC!

…os_touch_fix

For now this PR only checks for auto in width or height. This is clearly not enough. But the idea is to check if it is necessary to requestLayout on the parent. Most of the times it is not necessary. In the case of a complex app the improvements is huge!. It makes apps using animations (not using {N} animation system which is too limited) far more snappier. This is only a POC!

…mprovements # Conflicts: # tns-core-modules/ui/core/view/view.android.ts # tns-core-modules/ui/gestures/gestures.ios.ts

…into layout_improvements

vtrifonov · 2020-01-17T14:41:46Z

    }

-    public requestLayout(): void {
+    public requestLayout(calledFromChild?:boolean): void {


Space is needed after the colon in parameter to match the tslint rules

Suggested change

public requestLayout(calledFromChild?:boolean): void {

public requestLayout(calledFromChild?: boolean): void {

vtrifonov · 2020-01-17T14:44:28Z

-        super.requestLayout();
-        if (this.nativeViewProtected) {
-            this.nativeViewProtected.requestLayout();
+    public requestLayout(calledFromChild?:boolean): void {


Space is needed after the colon in parameter to match the tslint rules

Suggested change

public requestLayout(calledFromChild?:boolean): void {

public requestLayout(calledFromChild?: boolean): void {

vtrifonov · 2020-01-17T14:44:54Z


-    public requestLayout(): void {
-        super.requestLayout();
+    public requestLayout(calledFromChild?:boolean): void {


Space is needed after the colon in parameter to match the tslint rules

Suggested change

public requestLayout(calledFromChild?:boolean): void {

public requestLayout(calledFromChild?: boolean): void {

vtrifonov · 2020-01-17T14:45:36Z

+        if (this._isLayoutValid) {
+            return;
+        }
+        const width = this.getMeasuredWidth()


Missing semicolon

Suggested change

const width = this.getMeasuredWidth()

const width = this.getMeasuredWidth();

vtrifonov · 2020-01-17T14:45:48Z

+            return;
+        }
+        const width = this.getMeasuredWidth()
+        const height = this.getMeasuredHeight()


Missing semicolon

Suggested change

const height = this.getMeasuredHeight()

const height = this.getMeasuredHeight()

vtrifonov · 2020-01-17T14:56:34Z

    public isPlaying: boolean;
    // Warning: (ae-forgotten-export) The symbol "AnimationPromise" needs to be exported by the entry point index.d.ts
-    //
+    // 


Can you remove all these spaces?

vtrifonov · 2020-01-17T14:57:06Z

     * Invalidates the layout of the view and triggers a new layout pass.
     */
-    public requestLayout(): void;
+    public requestLayout(calledFromChild?:boolean): void;


Space is needed after the colon in parameter to match the tslint rules

Suggested change

public requestLayout(calledFromChild?:boolean): void;

public requestLayout(calledFromChild?: boolean): void;

farfromrefug · 2020-01-17T15:36:28Z

@vtrifonov sorry about that :s All lint errors fixed

vtrifonov · 2020-01-20T13:27:06Z

@farfromrefug, sorry, it should remain:

public requestLayout(calledFromChild?:boolean): void;

(without space after the parameter) in the api-reports/NativeScript.api.json file. You'd better run

npm run api-extractor

and then commit the api-reports/NativeScript.api.json file.

Update NativeScript.api.md

farfromrefug · 2020-01-20T14:13:47Z

@farfromrefug, sorry, it should remain:
public requestLayout(calledFromChild?:boolean): void;
(without space after the parameter) in the api-reports/NativeScript.api.json file. You'd better run
npm run api-extractor
and then commit the api-reports/NativeScript.api.json file.

My bad thought it was an error on my side :s

…tLayout

…into layout_improvements

…yout_improvements # Conflicts: # nativescript-core/ui/core/view-base/view-base.ts

…t attached

farfromrefug · 2020-02-28T18:47:41Z

I used those changes inside an app of mine.
We can easily the difference in the profiling

The first one is with {N} current behavior. The next one with those changes.
You can the deep calls to requestLayout on the first one. And they are not needed as the actual parent StackLayout(16) is not attached yet.

farfromrefug · 2020-02-29T06:47:38Z

@NathanaelA I honestly don't want to talk in time. More in unecessery deep calls..and in some cases those calls are long. But obviously there s time gain from this, not easy to compute though.

NathanWalker · 2020-06-13T21:05:49Z

@farfromrefug flagging for 7.0 as we can test these changes with all other planned changes for 7.0 👍

farfromrefug · 2020-06-14T06:34:16Z

@NathanWalker this PR mostly exists to show the possible issues we have we layout

NathanWalker · 2020-10-27T20:55:11Z

@farfromrefug we would like to get some of these improvements in for 8.0 and curious if you would want to collaborate on anything remaining here?

farfromrefug · 2020-10-27T22:31:05Z

I am willing but it requires a lot of thinking. Upon deeper look at the iOS implementation it has a very deep flow. A view cannot request it s own relayout. It has to go all the way up to the view controller. We need to looknif this is fixable. Otherwise this PR should be discarded (hopefully not)

farfromrefug and others added 16 commits July 25, 2018 10:59

fix ios Touch gestures super methods not being called on nativeView

23e3526

Merge branch 'master' into ios_touch_fix

0d66e51

use “this.view”

2f8fa6e

Merge branch 'ios_touch_fix' of github.com:Akylas/NativeScript into i…

aafcd07

…os_touch_fix

propagate gesture touch to parent so that gestures can work

ef3a2df

Merge branch 'ios_touch_fix'

a10d3ff

Merge branch 'master' into layout_improvements

1077c6d

Merge branch 'master' into layout_improvements

becc6e2

Merge branch 'master' into layout_improvements

cb61864

Merge branch 'master' into layout_improvements

8389999

updated api

2c89909

Merge branch 'master' of github.com:Akylas/NativeScript into layout_i…

e469f2a

…mprovements # Conflicts: # tns-core-modules/ui/core/view/view.android.ts # tns-core-modules/ui/gestures/gestures.ios.ts

Merge branch 'master' into layout_improvements

5ea9ef7

fix: update requestLayout signature

82bcc04

Merge branch 'layout_improvements' of github.com:Akylas/NativeScript …

fd779e2

…into layout_improvements

cla-bot Bot added the cla: yes label Jan 17, 2020

vtrifonov suggested changes Jan 17, 2020

View reviewed changes

chore: lint erro rfixes

7ebe403

vtrifonov and others added 2 commits January 20, 2020 15:34

Update NativeScript.api.md

32e3e49

Merge pull request #1 from vtrifonov/patch-2

07b37af

Update NativeScript.api.md

vtrifonov approved these changes Jan 20, 2020

View reviewed changes

farfromrefug added 2 commits February 6, 2020 09:53

fix: report fix

8bcc751

fix: ignore requestLayout if not loaded

1149e98

farfromrefug mentioned this pull request Feb 24, 2020

creating a view is actually very slow #8313

Open

farfromrefug added 2 commits February 26, 2020 14:50

ignore requestlyaout if the view is not loaded

da462d0

only set _isLoaded after children creation to prevent unwanted reques…

322bafb

…tLayout

farfromrefug added 5 commits February 26, 2020 15:28

Merge branch 'layout_improvements' of github.com:Akylas/NativeScript …

ec2fb3e

…into layout_improvements

fix: no need to run bachUpdate if no matchingSelectors

44cc914

Merge branch 'master' of github.com:NativeScript/NativeScript into la…

5da0d7e

…yout_improvements # Conflicts: # nativescript-core/ui/core/view-base/view-base.ts

prevent calls to requestLayout when view (or any of its parent) is no…

996f5a0

…t attached

lint fixes

6e1ac93

This comment was marked as abuse.

Sign in to view

NathanWalker force-pushed the master branch from 8753605 to 86395da Compare September 10, 2020 15:42

NathanWalker force-pushed the master branch from d4ced42 to 53488b5 Compare September 25, 2020 23:16

NathanWalker added this to the 8.0 milestone Oct 27, 2020

NathanWalker changed the base branch from master to release/8.0.0 January 21, 2021 17:34

NathanWalker changed the title ~~testing improvements on layout~~ perf: faster view layout handling Jan 21, 2021

NathanWalker marked this pull request as ready for review January 29, 2021 19:45

rigor789 removed this from the 8.0 milestone Aug 4, 2021

NathanWalker added this to the 8.4 milestone Aug 16, 2022

NathanWalker removed this from the 8.4 milestone Nov 24, 2022

	public requestLayout(calledFromChild?:boolean): void {
	public requestLayout(calledFromChild?: boolean): void {

	const width = this.getMeasuredWidth()
	const width = this.getMeasuredWidth();

	const height = this.getMeasuredHeight()
	const height = this.getMeasuredHeight()

Uh oh!

Conversation

farfromrefug commented Jan 17, 2020

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

vtrifonov Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

farfromrefug commented Jan 17, 2020

Uh oh!

vtrifonov commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

farfromrefug commented Jan 20, 2020

Uh oh!

farfromrefug commented Feb 28, 2020

Uh oh!

This comment was marked as abuse.

farfromrefug commented Feb 29, 2020

Uh oh!

NathanWalker commented Jun 13, 2020

Uh oh!

farfromrefug commented Jun 14, 2020

Uh oh!

NathanWalker commented Oct 27, 2020

Uh oh!

farfromrefug commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vtrifonov commented Jan 20, 2020 •

edited

Loading